Create shoot cluster per default without overlay network for kubernetes >= 1.22. #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/networking
|
@ScheererJ Thank you for your contribution. |
|
@ScheererJ You need rebase this pull request with latest master branch. Please check. |
gardener-robot
added
needs/review
gardener-robot-ci-2
added
reviewed/ok-to-test
…es >= 1.22. Unless explicitly specified, the overlay network is disabled with a mutating webhook for new clusters. This only works for clusters >= 1.22 due to the source/destinations checks being disabled only for those clusters (see gardener/machine-controller-manager-provider-aws#36 for details).
ScheererJ
force-pushed
the
network-webhook/disable-overlay-network
branch
from
b028638 to
0262b79
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area networking
/kind enhancement
/platform aws
What this PR does / why we need it:
Create shoot cluster per default without overlay network for kubernetes >= 1.22.
Unless explicitly specified, the overlay network is disabled with a mutating
webhook for new clusters. This only works for clusters >= 1.22 due to the
source/destinations checks being disabled only for those clusters (see
gardener/machine-controller-manager-provider-aws#36
for details).
Prerequisite for https://github.com/gardener/backlog/issues/29.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
This requires the routes for the per node pod cidrs to be created in the infrastructure as a prerequisite. This could be done by cloud-controller-manager. Unfortunately, aws cloud-controller-manager does not work with multiple route tables, which are used by gardener (one per availability zone + a global one).
Therefore, this pull request is a draft for now.
#591 is the prerequisite for this change.
Release note: