Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop CRDs dnslock and remoteaccesscertificates #381

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Drop CRDs dnslock and remoteaccesscertificates #381

merged 1 commit into from
Aug 16, 2024

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
This is a cleanup PR.
The experimental and unused CRDs dnslock.dns.gardener.cloud and remoteaccesscertificates.dns.gardener.cloud are dropped and the code simplified.
Additionally, the obsolete dedicate build has been removed.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Drop support for custom resources `dnslock.dns.gardener.cloud` and `remoteaccesscertificates.dns.gardener.cloud`.
As these experimental features have no been used in Gardener, it should not be relevant in most cases.

@MartinWeindel MartinWeindel requested a review from a team as a code owner July 26, 2024 11:34
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jul 26, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 26, 2024
@MartinWeindel MartinWeindel merged commit 5e00b9f into master Aug 16, 2024
8 checks passed
@MartinWeindel MartinWeindel deleted the cleanup-drop-dnslock branch August 16, 2024 07:17
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinWeindel @gardener-robot-ci-3 @gardener-robot