Refactoring: constant for "hostedzone:" (#10)

gardener · Feb 18, 2019 · 35767e7 · 35767e7
1 parent fc17227
commit 35767e7
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/pkg/dns/provider/const.go b/pkg/dns/provider/const.go
@@ -20,6 +20,10 @@ package provider
   Standard options a DNS Reconciler should offer
 */
 
-const OPT_IDENTIFIER = "identifier"
-const OPT_DRYRUN = "dry-run"
-const OPT_TTL = "ttl"
+const (
+	OPT_IDENTIFIER = "identifier"
+	OPT_DRYRUN     = "dry-run"
+	OPT_TTL        = "ttl"
+
+	HOSTEDZONE_PREFIX = "hostedzone:"
+)
diff --git a/pkg/dns/provider/controller.go b/pkg/dns/provider/controller.go
@@ -17,9 +17,10 @@
 package provider
 
 import (
+	"time"
+
 	"github.com/gardener/external-dns-management/pkg/crds"
 	"github.com/gardener/external-dns-management/pkg/dns/source"
-	"time"
 
 	"github.com/gardener/controller-manager-library/pkg/controllermanager/controller"
 	"github.com/gardener/controller-manager-library/pkg/controllermanager/controller/reconcile"
@@ -64,7 +65,7 @@ func DNSController(name string, factory DNSHandlerFactory) controller.Configurat
 			controller.NewResourceKey(api.GroupName, api.DNSProviderKind),
 			controller.NewResourceKey("core", "Secret"),
 		).
-		WorkerPool("dns", 1, 30*time.Second).CommandMatchers(utils.NewStringGlobMatcher("hostedzone:*"))
+		WorkerPool("dns", 1, 30*time.Second).CommandMatchers(utils.NewStringGlobMatcher(HOSTEDZONE_PREFIX + "*"))
 }
 
 type reconciler struct {

diff --git a/pkg/dns/provider/state.go b/pkg/dns/provider/state.go
@@ -391,7 +391,7 @@ func (this *state) getZoneForName(hostname string) (string, int) {
 }
 
 func (this *state) triggerHostedZone(name string) {
-	cmd := "hostedzone:" + name
+	cmd := HOSTEDZONE_PREFIX + name
 	if this.controller.IsReady() {
 		this.controller.EnqueueCommand(cmd)
 	} else {
@@ -408,8 +408,8 @@ func (this *state) triggerKey(key resources.ClusterObjectKey) {
 }
 
 func (this *state) DecodeZoneCommand(name string) string {
-	if strings.HasPrefix(name, "hostedzone:") {
-		return name[len("hostedzone:"):]
+	if strings.HasPrefix(name, HOSTEDZONE_PREFIX) {
+		return name[len(HOSTEDZONE_PREFIX):]
 	}
 	return ""
 }