Skip to content

Commit

Permalink
allow underscore in DNS names
Browse files Browse the repository at this point in the history
  • Loading branch information
MartinWeindel committed May 13, 2019
1 parent 7db1b76 commit 17dd869
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkg/dns/provider/entry.go
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,10 @@ func validate(state *state, entry *EntryVersion) (targets Targets, warnings []st
check := entry.object.GetDNSName()
if strings.HasPrefix(check, "*.") {
check = check[2:]
} else if strings.HasPrefix(check, "_") {
check = check[1:]
}

if errs := validation.IsDNS1123Subdomain(check); errs != nil {
if werrs := validation.IsWildcardDNS1123Subdomain(check); werrs != nil {
err = fmt.Errorf("%q is no valid dns name (%v)", check, append(errs, werrs...))
Expand Down

0 comments on commit 17dd869

Please sign in to comment.