Add code to remove legacy validation_marker file that created by etcd-custom-image on the filesystem

internal/app/app.go

@@ -93,7 +93,7 @@ func (a *Application) Start() error {
 	if err = a.startEtcd(); err != nil {
 		return err
 	}
-	// Delete validation marker after etcd starts successfully
+	// Delete exit code file after etcd starts successfully
 	if err = bootstrap.CleanupExitCode(types.DefaultExitCodeFilePath); err != nil {
 		a.logger.Warn("failed to clean-up last captured exit code", zap.Error(err))
 	}

internal/bootstrap/bootstrap.go

@@ -115,6 +115,12 @@ func (i *initializer) tryGetEtcdConfig(ctx context.Context, maxRetries int, inte
 
 func determineValidationMode(exitCodeFilePath string, logger *zap.Logger) brclient.ValidationType {
 	var err error
+
+	// remove legacy validation_marker file created by etcd-custom-image
+	if err = CleanupExitCode(types.ValidationMarkerFilePath); err != nil {
+		logger.Error("error in removing validation_marker file", zap.String("validationMarkerFilePath", types.ValidationMarkerFilePath), zap.Error(err))
+	}
+
 	if _, err = os.Stat(exitCodeFilePath); err == nil {
 		data, err := os.ReadFile(exitCodeFilePath) // #nosec G304 -- only path passed is `DefaultExitCodeFilePath`, no user input is used.
 		if err != nil {

internal/types/constants.go

@@ -13,6 +13,8 @@ const (
 	DefaultBackupRestoreHostPort = ":8080"
 	// DefaultExitCodeFilePath defines the default file path for the file that stores the exit code of the previous run
 	DefaultExitCodeFilePath = "/var/etcd/data/exit_code"
+	// ValidationMarkerFilePath defines the file path to the legacy file that was used to record exit code of the previous run
+	ValidationMarkerFilePath = "/var/etcd/data/validation_marker"
 	// DefaultLogLevel defines the default log level for any zap loggers created
 	DefaultLogLevel = zapcore.InfoLevel
 )