/invite @ishan16696

Hey Shreyas,
As I can see the code, there is already code present to clean-up the exit code after etcd successfully starts.

May be what you have seen could be some edge cases in which etcd-wrapper failed to remove old validation_marker.
Can you make changes in same file like this:

	// Delete legacy validation marker after etcd starts successfully
        // TODO: To be removed in next release
	if err = bootstrap.CleanupExitCode(types.LegacyValidationMarkerFilePath); err != nil {
		a.logger.Warn("failed to clean-up legacy exit code file", zap.Error(err))
	}

@ishan16696 that code cleans up the new exit_code file, but not validation_marker. Seems to be a mistake in the comment on line 96 that says Delete validation marker after etcd starts successfully instead of saying Delete exit code file after etcd starts successfully.

So deletion of validation_marker file is necessary, via this PR. I'll fix the old comment as well.

that code cleans up the new exit_code file, but not validation_marker

validation_marker is just a file name, you can call it either exit_code file or validation_marker file but both of them captures the exit code of etcd. It just file path has changed.
So, my point was there is already a code in place which removes the file which captures the exit code, and may be due to some edge case for which etcd-wrapper failed to remove old exit code file (i.e validation_marker file).

I'm saying can we reuse the same func and just pass the old path of exit code file (i.e validation_marker file).

	// Delete legacy validation marker after etcd starts successfully
        // TODO: To be removed in next release
	if err = bootstrap.CleanupExitCode(....); err != nil {
		a.logger.Warn("failed to clean-up legacy exit code file", zap.Error(err))
	}

@ishan16696 not really. etcd-wrapper is designed to delete the exit_code file after the etcd process starts, so that an abrupt kill of the etcd-wrapper container does not lead to a wrong validation mode upon restart. Ok, I now understand that you want to re-use the CleanupExitCode() function for doing this, correct? My bad for not reading the previous comment correctly, sorry 😅.

I've pushed the change as requested. PTAL.