Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependency on github.com/gardener/etcd-backup-restore to v0.31.0. #924

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Upgrade dependency on github.com/gardener/etcd-backup-restore to v0.31.0. #924

merged 1 commit into from
Nov 13, 2024

Conversation

renormalize
Copy link
Member

@renormalize renormalize commented Nov 13, 2024 •
edited
Loading

How to categorize this PR?

/area delivery
/kind enhancement

What this PR does / why we need it:

  • Upgrade the etcdbrctl dependency in internal/images/images.yaml to use europe-docker.pkg.dev/gardener-project/public/gardener/etcdbrctl:v0.31.0.

  • Upgrade dependency on github.com/gardener/etcd-backup-restore to v0.31.0 in go.mod.

  • Upgrade indirect dependencies.

  • Adapt test/e2e/utils.go to use the newer List API of SnapStore in etcd-backup-restore.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Upgraded `github.com/gardener/etcd-backup-restore` dependency from `0.29.0` to `0.31.0`.

Upgraded `etcd-backup-restore` image version to `v0.31.0`.

Improves the `renewTime` of full snapshot lease when the lease is updated as part of retry mechanism

Improved error handling in deletion of delta snapshots during snapshot garbage collection.

`etcd-backup-restore` now uses the `Restore` API exposed by `go.etcd.io/etcd/clientv3/snapshot` to perform restoration of the etcd data directory, moving away from performing restoration of the data directory manually.

`etcd-backup-restore` now uses etcd version `v3.4.34` for the embedded etcd during restoration.

Standardize the `yaml` dependency to `sigs.k8s.io/yaml`. Replace deprecated `k8s.io/utils/pointer` with `k8s.io/utils/ptr`. Bump all direct dependencies to newer versions.

Builds for non-native platforms can now be done using the `docker-build` make target instead of having to invoke the `docker buildx` command. The platform can be specified using the `PLATFORM` variable which is passed while invoking make.

Upgrade the Go dependency to `go1.23.2`.

Azure Blob Storage client Go module upgraded to github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from the deprecated github.com/Azure/azure-storage-blob-go

@renormalize
Upgrade dependency on github.com/gardener/etcd-backup-restore to `v…
686668e 
…0.31.0`.

* Upgrade the `etcdbrctl` dependency in `internal/images/images.yaml` to
  use `europe-docker.pkg.dev/gardener-project/public/gardener/etcdbrctl:v0.31.0`.

* Upgrade dependency on `github.com/gardener/etcd-backup-restore` to
  `v0.31.0` in `go.mod`.

* Upgrade indirect dependencies.

* Adapt `test/e2e/utils.go` to use the newer `List` API of `SnapStore` in
  `etcd-backup-restore`.
@renormalize renormalize requested a review from a team as a code owner November 13, 2024 08:45
@gardener-robot gardener-robot added needs/review Needs review area/backup Backup related area/delivery Delivery related kind/enhancement Enhancement, improvement, extension size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 13, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 13, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 13, 2024
@renormalize renormalize self-assigned this Nov 13, 2024
@renormalize renormalize added this to the v0.24.0 milestone Nov 13, 2024
anveshreddy18
anveshreddy18 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@anveshreddy18 anveshreddy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade and neat release notes. 🚀
LGTM!

@anveshreddy18 anveshreddy18 removed their assignment Nov 13, 2024
@renormalize
Copy link
Member Author

/retest-required

@gardener gardener deleted a comment from gardener-prow bot Nov 13, 2024
@renormalize renormalize merged commit 386ff75 into gardener:master Nov 13, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

@anveshreddy18 anveshreddy18 anveshreddy18 approved these changes

Assignees

@renormalize renormalize

Labels
area/backup Backup related area/delivery Delivery related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.
6 participants
@renormalize @anveshreddy18 @seshachalam-yv @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot