Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some github pages links #919

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fixed some github pages links #919

merged 1 commit into from
Nov 13, 2024

Conversation

unmarshall
Copy link
Contributor

How to categorize this PR?

/area documentation
/kind bug

What this PR does / why we need it:
Fixes some links that are outside the /doc folder. Clicking on these links was returning a 404.

Release note:

Fixes github pages links

@unmarshall unmarshall requested a review from a team as a code owner November 13, 2024 04:42
@gardener-robot gardener-robot added area/documentation Documentation related kind/bug Bug needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 13, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 13, 2024
seshachalam-yv
seshachalam-yv approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 13, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 13, 2024
@unmarshall
Copy link
Contributor Author

/retest

@unmarshall unmarshall merged commit 3611836 into gardener:master Nov 13, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 13, 2024
@unmarshall unmarshall deleted the fixdoclinks branch December 12, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

Assignees
No one assigned
Labels
area/documentation Documentation related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@unmarshall @seshachalam-yv @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot