Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CherryPick-915] Fix to allow etcd-druid to patch STS when there is only a change of m… #918

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[CherryPick-915] Fix to allow etcd-druid to patch STS when there is only a change of m… #918

merged 1 commit into from
Nov 12, 2024

Conversation

unmarshall
Copy link
Contributor

…ount-path even if all pods are not up and running (#915)

How to categorize this PR?

/area control-plane
/kind bug

What this PR does / why we need it:
Cherry pick of PR #915

Which issue(s) this PR fixes:
Fixes #908 and #914

Special notes for your reviewer:

Release note:

Fixes etcd client and peer service label selector, ensuring that only Etcd statefulset pods are selected.

etcd controller now differentiates between TLS configuration change and peer TLS enablement. Only if peer TLS has been enabled and not yet reflected it will wait for all pods to come up else it will allow patching of statefulset.

@unmarshall
Fix to allow etcd-druid to patch STS when there is only a change of m…
0e9a116 
…ount-path even if all pods are not up and running (gardener#915)
@unmarshall unmarshall requested a review from a team as a code owner November 12, 2024 11:06
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/bug Bug labels Nov 12, 2024
@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Nov 12, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 12, 2024
ishan16696
ishan16696 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@unmarshall
Copy link
Contributor Author

/retest

@unmarshall unmarshall merged commit 5305221 into gardener:hotfix-v0.23 Nov 12, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 12, 2024
@ishan16696 ishan16696 deleted the cherrypick-915 branch November 12, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

@ishan16696 ishan16696 ishan16696 approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@unmarshall @ishan16696 @seshachalam-yv @gardener-robot-ci-2 @gardener-robot