Use full snapshot interval to compute Backup Ready conditions #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
renormalize
approved these changes
Nov 6, 2024
renormalize
reviewed
Nov 6, 2024
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
|
/test pull-etcd-druid-e2e-kind |
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area backup
/area monitoring
/kind bug
What this PR does / why we need it:
Backup ready condition is determined based on the snapshot intervals and the time the snapshot is taken. Currently, the full snapshot interval is hardcoded as
24hrin the code here & here which can lead to a false positiveBackupReady : trueif the user has configured the full snapshot schedule to be less than24hrOR can lead to a false negativeBackupReady : falsecondition if the user has configured the schedule to be more than24hr.This PR uses the full snapshot interval fetched from the etcd spec at
etcd.Spec.Backup.FullSnapshotScheduleinstead of assuming it as24hrs.Which issue(s) this PR fixes:
Fixes #905
Special notes for your reviewer:
Release note: