Add additional latest tag to images during release #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
|
/test pull-etcd-druid-e2e-kind |
renormalize
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Thanks for this feature which will be very useful @anveshreddy18!
Will save us a lot of pain during testing.
It'd be great if you could reflect these changes on etcd-backup-restore as well!
Sure @renormalize, backup-restore helm charts need to be updated, so will do it then if that's okay. |
gardener-robot
added
the
status/closed
shreyas-s-rao
pushed a commit
that referenced
this pull request
Oct 23, 2024
* Add latest tag to images during release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area delivery
/kind enhancement
What this PR does / why we need it:
Add
latesttag to every image built as part of the release job in the CI pipeline.This is to consume the helm charts as it is, currently it expects a
latesttag for theetcd-druidimage which it cannot find from theeurope-dockerregistry as we currently only haveversionspecific tags. Adding thelatesttag would make it better for open-source consumers to quickly test the functionality, as we have seen cases of people reporting the missing tag.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: