Fixes Label-Selector, Pod Template label updates and TLS changes for client and peer communication #883

unmarshall · 2024-10-01T03:49:14Z

How to categorize this PR?

/area control-plane
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #881

Special notes for your reviewer:

Release note:

Fixed the ready condition for the Etcd resource.

Fixes for handling of pod template labels, label-selector, replicas and TLS changes to Etcd resource. StatefulSet does not allow update of label-selector. v0.23.x changes the label-selector, to get that reflected in the STS, it will be orphan deleted and subsequently created. Similarly for peer TLS and pod label changes an update of pods will be done. For single member etcd clusters this will cause a transient downtime. If replicas, TLS, label-selector are changed together then it will also cause transient quorum loss in multi-node etcd clusters.

etcd-backup-restore has been bumped to v0.30.2 and etcd-wrapper has been bumped to v0.2.0.

If you wish to downgrade from druid `v0.23.x` to versions =<`v0.22.7`, please ensure that you change the CLI flags for the druid command to remove the new CLI flags introduced in `v0.23.0`. If you are using the provided helm charts to deploy druid, you may ignore this and simply deploy the helm chart, which takes care of the CLI flag changes for you.

etcd-backup-restore now triggers a restart of the etcd member after updating etcd's advertise peer URLs if found updated.

Introduced a CLI flag `--use-etcd-wrapper` (default: false) to enable/disable the backup-restore to use etcd-wrapper related functionality. Note: enable this flag only if etcd-wrapper is deployed.

Added a capability to stop the etcd-wrapper container by exposing an endpoint `/stop`.

Upgrade the Go dependency to `go1.23.1`.

ops/print-etcd-cert-paths.sh has been removed and is now replaced with ops/print-etcd-cheatsheet.sh

unmarshall · 2024-10-01T04:05:22Z

/test pull-etcd-druid-e2e-kind

unmarshall · 2024-10-01T04:05:30Z

/test pull-etcd-druid-e2e-kind-nondistroless-etcd

ishan16696 · 2024-10-01T08:38:59Z

@unmarshall can you also mention the test cases for which you have tested this PR.

unmarshall · 2024-10-01T10:22:12Z

/test pull-etcd-druid-e2e-kind

unmarshall · 2024-10-01T10:22:20Z

/test pull-etcd-druid-e2e-kind-nondistroless-etcd

unmarshall · 2024-10-01T14:02:30Z

/test pull-etcd-druid-e2e-kind-nondistroless-etcd

unmarshall · 2024-10-01T14:44:03Z

/test pull-etcd-druid-e2e-kind

Added ability to handle unknown CLI args to allow switching between v0.22 and v0.23 Added use-etcd-wrapper cli arg for etcdbr container

…tore while keep etcd.spec.replicas > 1

shreyas-s-rao

Thanks for making all the requested changes!

/lgtm

ishan16696

LGTM!!

ishan16696 · 2024-10-23T12:22:20Z

Before merging the PR @unmarshall please update the release notes as you have reverted the change of adding the cluster-size annotation.

shreyas-s-rao · 2024-10-23T12:36:20Z

@ishan16696 done, thanks!

…client and peer communication (gardener#883) * fixes gardener#881, gardener#877 * Added ability to handle unknown CLI args to allow switching between v0.22 and v0.23 * Added use-etcd-wrapper cli arg for etcdbr container * removed etcd-cluster-size label to be added later with ability to restore while keep etcd.spec.replicas > 1

shreyas-s-rao · 2024-10-23T13:20:48Z

/cherry-pick hotfix-v0.23

…client and peer communication (#883) (#894) * fixes #881, #877 * Added ability to handle unknown CLI args to allow switching between v0.22 and v0.23 * Added use-etcd-wrapper cli arg for etcdbr container * removed etcd-cluster-size label to be added later with ability to restore while keep etcd.spec.replicas > 1 Co-authored-by: Madhav Bhargava <[email protected]>

unmarshall requested a review from a team as a code owner October 1, 2024 03:49

gardener-robot added area/control-plane Control plane related kind/bug Bug needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Oct 1, 2024

unmarshall mentioned this pull request Oct 1, 2024

Adds etcd-cluster-size pod label and fixes handling of simultaneous changes to Peer TLS, Replicas and Pod labels #882

Closed

gardener-robot added the needs/second-opinion Needs second review by someone else label Oct 1, 2024

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 1, 2024

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 1, 2024

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 2, 2024

unmarshall force-pushed the fixv0.23 branch from 7e55c1d to a3f3d59 Compare October 7, 2024 09:01

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 7, 2024

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 7, 2024

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 8, 2024

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024

fixes gardener#881, gardener#877

1a14060

Added ability to handle unknown CLI args to allow switching between v0.22 and v0.23 Added use-etcd-wrapper cli arg for etcdbr container

unmarshall force-pushed the fixv0.23 branch from 0c2ffdf to 1a14060 Compare October 23, 2024 07:56

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 23, 2024

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024

unmarshall requested review from shreyas-s-rao October 23, 2024 09:38

removed etcd-cluster-size label to be added later with ability to res…

24a85b1

…tore while keep etcd.spec.replicas > 1

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024

shreyas-s-rao approved these changes Oct 23, 2024

View reviewed changes

gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Oct 23, 2024

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024

ishan16696 approved these changes Oct 23, 2024

View reviewed changes

shreyas-s-rao merged commit 8b9fb87 into gardener:master Oct 23, 2024
11 checks passed

gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 23, 2024

gardener-robot added the needs/cherry-pick Needs to be cherry-picked to older version label Oct 23, 2024

This was referenced Oct 23, 2024

Add cluster size indicator label to etcd pods #877

Open

[hotfix-v0.23] Fixes Label-Selector, Pod Template label updates and TLS changes for client and peer communication (#883) #894

Merged

unmarshall deleted the fixv0.23 branch October 23, 2024 14:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes Label-Selector, Pod Template label updates and TLS changes for client and peer communication #883

Fixes Label-Selector, Pod Template label updates and TLS changes for client and peer communication #883

unmarshall commented Oct 1, 2024 •

edited

Loading

unmarshall commented Oct 1, 2024

unmarshall commented Oct 1, 2024

ishan16696 commented Oct 1, 2024

unmarshall commented Oct 1, 2024

unmarshall commented Oct 1, 2024

unmarshall commented Oct 1, 2024

unmarshall commented Oct 1, 2024

shreyas-s-rao left a comment

ishan16696 left a comment

ishan16696 commented Oct 23, 2024 •

edited

Loading

shreyas-s-rao commented Oct 23, 2024

shreyas-s-rao commented Oct 23, 2024

Fixes Label-Selector, Pod Template label updates and TLS changes for client and peer communication #883

Fixes Label-Selector, Pod Template label updates and TLS changes for client and peer communication #883

Conversation

unmarshall commented Oct 1, 2024 • edited Loading

unmarshall commented Oct 1, 2024

unmarshall commented Oct 1, 2024

ishan16696 commented Oct 1, 2024

unmarshall commented Oct 1, 2024

unmarshall commented Oct 1, 2024

unmarshall commented Oct 1, 2024

unmarshall commented Oct 1, 2024

shreyas-s-rao left a comment

Choose a reason for hiding this comment

ishan16696 left a comment

Choose a reason for hiding this comment

ishan16696 commented Oct 23, 2024 • edited Loading

shreyas-s-rao commented Oct 23, 2024

shreyas-s-rao commented Oct 23, 2024

unmarshall commented Oct 1, 2024 •

edited

Loading

ishan16696 commented Oct 23, 2024 •

edited

Loading