Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the docker-build make target to build for multiple platforms. #873

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Enhance the docker-build make target to build for multiple platforms. #873

merged 1 commit into from
Sep 11, 2024

Conversation

renormalize
Copy link
Member

@renormalize renormalize commented Sep 6, 2024 •
edited
Loading

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:

  • The docker-build make target builds the image for the architecture of the host machine (same behavior as before).

  • The platform can be overridden by passing this variable directly to the make command like PLATFORM=linux/arm64 make docker-build, PLATFORM=linux/amd64 make docker-build, etc.

Release note:

Builds for non-native platforms can now be done using the `docker-build` make target instead of having to invoke the `docker buildx` command. The platform can be specified using the `PLATFORM` variable which is passed while invoking make.

@renormalize renormalize requested a review from a team as a code owner September 6, 2024 08:18
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 6, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 6, 2024
@renormalize renormalize self-assigned this Sep 6, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 6, 2024
@renormalize
Enhance the docker-build make target to build for multiple platforms.
80a9033 
* The `docker-build` make target builds the image for the architecture
  of the host machine.

* The platform can be overridden by passing this variable directly to the
  make command like `PLATFORM=linux/arm64 make docker-build`,
  `PLATFORM=linux/amd64 make docker-build`.
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 9, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 9, 2024
seshachalam-yv
seshachalam-yv approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 11, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 11, 2024
@renormalize renormalize merged commit 81dbd51 into gardener:master Sep 11, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 11, 2024
@renormalize renormalize deleted the docker-platform branch November 15, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

Assignees

@renormalize renormalize

Labels
area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@renormalize @seshachalam-yv @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot