Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests by ensuring necessary pods are created #839

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Fix integration tests by ensuring necessary pods are created #839

merged 3 commits into from
Jul 23, 2024

Conversation

seshachalam-yv
Copy link
Contributor

@seshachalam-yv seshachalam-yv commented Jul 23, 2024 •
edited
Loading

How to categorize this PR?

/area testing
/kind bug

What this PR does / why we need it:

This PR fixes integration test failures observed after merging PR #804, which added new Kubernetes-recommended labels to etcd pods. The existing tests failed because they expected these pods to be present to verify the labels, but the pods were not created in the test environment. This PR resolves the issue by ensuring that the necessary StatefulSet pods are created and subsequently cleaned up within the integration tests.

Which issue(s) this PR fixes:
Fixes #831

Special notes for your reviewer:

Release note:

Fixes integration test failures by ensuring necessary StatefulSet pods are created and deleted appropriately during tests to align with updates made in PR [#804](https://github.com/gardener/etcd-druid/pull/804).

@seshachalam-yv seshachalam-yv requested a review from a team as a code owner July 23, 2024 11:02
@gardener-robot gardener-robot added needs/review Needs review area/testing Testing related kind/bug Bug size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jul 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 23, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 23, 2024
unmarshall
unmarshall approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 23, 2024
ishan16696
ishan16696 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

shreyas-s-rao
shreyas-s-rao requested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seshachalam-yv thanks for the fix. Please address the review comments. Other than that, LGTM 👍

test/integration/controllers/etcd/reconciler_test.go Outdated Show resolved Hide resolved
test/integration/controllers/etcd/reconciler_test.go Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 23, 2024
@ishan16696
Copy link
Member

/retest

shreyas-s-rao
shreyas-s-rao approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ishan16696 ishan16696 merged commit 5a69463 into gardener:hotfix-v0.22 Jul 23, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 23, 2024
@seshachalam-yv seshachalam-yv deleted the integration-test-fix branch July 23, 2024 22:25
@ishan16696 ishan16696 mentioned this pull request Jul 24, 2024
Closed
@nschad nschad mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan16696 ishan16696 ishan16696 approved these changes

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

@unmarshall unmarshall unmarshall approved these changes

Assignees
No one assigned
Labels
area/testing Testing related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@seshachalam-yv @ishan16696 @unmarshall @shreyas-s-rao @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot