-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance E2E
Test Suite to support Parallel Execution
#833
Enhance E2E
Test Suite to support Parallel Execution
#833
Conversation
Skipping CI for Draft Pull Request. |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | - | Generic Private Key | ef0c014 | test/e2e/resources/tls/server.key | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
79c33f7
to
0946ea4
Compare
4234b88
to
c0837d3
Compare
c0837d3
to
13d8853
Compare
E2E
Test Suite to support Parallel Execution
Tested this change and it runs now in 4 processes for the tests and completed in ~10mins.
Running the same test on the master branch finished in 23mins.
This is cool and time saver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. In general i would recommend that ONLY refactorings which are absolutely essential for ensuring that the tests run concurrently should be kept.
Ensure that the GINKGO binary is required for running the ci-e2e-kind and ci-e2e-kind-azure targets.
- Introduce sync.Once to ensure secrets are deployed exactly once across concurrent tests, enhancing efficiency and avoiding redundant operations. - Implement checks to update secrets if they already exist, rather than failing on re-deployment. - Revise the deletion strategy for namespaces to ensure they are removed only after all associated etcd resources are verified to be deleted. - Refactor the zero-downtime validation job to improve readability and maintainability, aligning with best practices for script execution in test scenarios.
- Used unique etcd instance names per test case to prevent collisions in shared namespace, improving test isolation. - Refactor cleanup processes to ensure etcd instances are deleted at the end of each test.
7509f93
to
801abdf
Compare
I checked out this PR and ran
I know this PR does not resolve flaky e2e tests but only improves its run time. Just reporting in this ticket. |
I ran the tests locally and they passed.
|
How to categorize this PR?
/area testing
/kind enhancement
What this PR does / why we need it:
This PR enhances the e2e test suite by:
25 minutes
to12 minutes
.sync.Once
for the safe and efficient initialization of shared resources, such asTLS
secrets and bucket credentials, within the same namespace.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Why Use Unique Names for etcd Test Cases?
etcd
test case to streamline DNS management. If each test used a unique namespace, it would require numerous DNS entries inserver.csr.conf
, such asetcd-{provider}.{NAMESPACE}.
Using a constant namespace simplifies DNS configuration and resource management across different providers.Release note: