Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use localstack-s3 image instead of localstack #805

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Use localstack-s3 image instead of localstack #805

merged 1 commit into from
Jun 24, 2024

Conversation

anveshreddy18
Copy link
Contributor

How to categorize this PR?

/area dev-productivity
/area storage
/kind test

What this PR does / why we need it:

This PR modifies the localstack image used for performing tests in druid. The current localstack image contains a lot of other services provided by AWS apart from S3 such as Lambda, DynamoDB, etc and has a compressed size of ~450 MB

The change proposes to use a much light weight version of this which provides only S3 services and has a compressed size of ~100 MB, which is a drastic reduction in size. This helps in faster setup for tests both locally and on pipelines as well.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

use `localstack:s3-latest` image instead of `localstack:latest` in tests for faster setup

@anveshreddy18 anveshreddy18 requested a review from a team as a code owner June 5, 2024 05:51
@gardener-robot gardener-robot added needs/review Needs review area/dev-productivity Developer productivity related (how to improve development) area/storage Storage related kind/test Test size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 5, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 5, 2024
renormalize
renormalize approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@renormalize renormalize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this find!

seshachalam-yv
seshachalam-yv approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anveshreddy18
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 5, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 5, 2024
@seshachalam-yv
Copy link
Contributor

/hold until #777

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jun 5, 2024
@shreyas-s-rao shreyas-s-rao added this to the v0.23.0 milestone Jun 5, 2024
@anveshreddy18 anveshreddy18 self-assigned this Jun 18, 2024
@shreyas-s-rao shreyas-s-rao merged commit 898ce3e into gardener:master Jun 24, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

@renormalize renormalize renormalize approved these changes

Assignees

@anveshreddy18 anveshreddy18

Labels
area/dev-productivity Developer productivity related (how to improve development) area/storage Storage related kind/test Test needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
6 participants
@anveshreddy18 @seshachalam-yv @renormalize @gardener-robot-ci-1 @shreyas-s-rao @gardener-robot