Move feature:etcd-wrapper from alpha to beta feature. #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/enhancement
gardener-robot
added
the
size/xs
gardener-robot-ci-3
added
reviewed/ok-to-test
|
/test pull-etcd-druid-e2e-kind-alpha-features |
shreyas-s-rao
requested changes
Jan 4, 2024
There was a problem hiding this comment.
@ishan16696 thanks for the PR. Just one comment regarding the doc. PTAL
gardener-robot-ci-1
added
reviewed/ok-to-test
|
@ishan16696 thanks for addressing my comment. Can you also take a look at gardener/ci-infra#1080 (comment) and address that as well in this PR? |
…not-use-feature-gates.
gardener-robot-ci-3
added
the
reviewed/ok-to-test
done, PTAL |
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
shreyas-s-rao
approved these changes
Jan 6, 2024
There was a problem hiding this comment.
@ishan16696 thanks for making the changes.
/lgtm
In the future, we need a better way to activate specific feature gates and deactivate others. Ideally, we need to have different combinations of profiles like alpha-on, alpha-on-beta-off, beta-off, etc, so that when we have multiple feature-gates available in druid, we can test these quite well.
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
3 tasks
ishan16696
added a commit
to ishan16696/etcd-druid
that referenced
this pull request
Jan 8, 2024
* Move feature:etcd-wrapper from alpha to beta feature. * Address review comments. * Adjusted the skafold activation profile with use-feature-gates to do-not-use-feature-gates.
ishan16696
added a commit
to ishan16696/etcd-druid
that referenced
this pull request
Jan 8, 2024
* Move feature:etcd-wrapper from alpha to beta feature. * Address review comments. * Adjusted the skafold activation profile with use-feature-gates to do-not-use-feature-gates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind enhancement
What this PR does / why we need it:
This PR moves
UseEtcdWrapperalpha feature to beta feature by setting it as the default option in etcd-druid.Which issue(s) this PR fixes:
Fixes Part1: #743
Special notes for your reviewer:
Release note: