[Bug] Fix Replica Count Update Bug in Custodian Controller #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where the Custodian Controller was not updating the replica count in the Etcd status, while the Etcd Controller in Druid was.This ensures that the replica count is accurately reflected in the Etcd status.
gardener-robot
added
area/control-plane
gardener-robot-ci-1
added
reviewed/ok-to-test
shreyas-s-rao
approved these changes
Oct 5, 2023
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind bug
What this PR does / why we need it:
This PR fixes a bug in the Custodian Controller which was not updating the replica count in the
etcdstatus, while theetcdController in Druid was. It ensures that theReplicasfield in theetcdstatus is accurately updated to reflect theCurrentReplicasfrom the StatefulSet status, similar to the behavior of theetcdController. This harmonizes the behavior between theetcdand Custodian Controllers, ensuring consistent replica count reflection in theetcdstatus.Which issue(s) this PR fixes:
Fixes # (Include the issue number if there is one)
Special notes for your reviewer:
Please review the added line
etcd.Status.Replicas = sts.Status.CurrentReplicasin theupdateEtcdStatusfunction within the Custodian Controller, ensuring it aligns with the project's coding standards and practices.Release note: