-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved scale-up detection. #647
Improved scale-up detection. #647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ishan16696 thanks for the PR. I feel this may not help solve the corner-case issue we see with scale-up today. Can you please address my comment? Thanks.
@unmarshall can you also take a look as I'm addressing your comments in this PR. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
MoM of out-of-band call between @ishan16696 ,@unmarshall and myself:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/area high-availability
/kind technical-debt
What this PR does / why we need it:
While testing this PR: gardener/etcd-backup-restore#649 I found out that when third member of etcd cluster won't come up but pod spec has been updated, so etcd statefulset's status
.status.updatedReplicas
becomes3
:druid remove the scale-up annotation:
gardener.cloud/scaled-to-multi-node
from etcd statefulset asfunc clusterScaledUpToMultiNode(){...} has returned false which is not correct.
more info please refer to this: #587 (comment), now it won't be an issue as backup-restore will skip checking scale-up conditions for first member
Which issue(s) this PR fixes:
Fixes # #587 (comment)
Special notes for your reviewer:
Release note: