Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes owner checks #461

Merged

Conversation

plkokanov
Copy link
Contributor

How to categorize this PR?

/area control-plane-migration
/kind cleanup

What this PR does / why we need it:
Removes owner checks as was decided in gardener/gardener#6302

Which issue(s) this PR fixes:
Part of gardener/gardener#6302

Special notes for your reviewer:
This PR depends on gardener/gardener#6988 as gardener should not try to set the owner check configuration on the Etcd resource if they are not supported by the etcd-druid. Alternatively Seeds can be configured so that the owner checks are disabled by setting spec.settings.ownerChecks.enabled to false.

Release note:

Removed ability to set owner checks that were used to restart the `etcd` process that runs in the source `Seed` cluster during "bad case" control plane migration.

@plkokanov plkokanov requested a review from a team as a code owner November 11, 2022 13:00
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 11, 2022
@gardener-robot gardener-robot added area/control-plane-migration Control plane migration related kind/cleanup Something that is not needed anymore and can be cleaned up needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 11, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 11, 2022
@ishan16696 ishan16696 self-assigned this Dec 12, 2022
@ishan16696
Copy link
Member

Hi @plkokanov ,
Can you please resolve the conflicts.

@plkokanov plkokanov force-pushed the cp-migration/remove-owner-checks branch from 03cdd21 to 5fb6df7 Compare December 22, 2022 15:12
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 22, 2022
@plkokanov
Copy link
Contributor Author

@ishan16696 done, ptal

@ishan16696 ishan16696 merged commit 09e62b2 into gardener:master Dec 23, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane-migration Control plane migration related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants