Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept 'openstack' for storage provider #43

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Accept 'openstack' for storage provider #43

merged 1 commit into from
Apr 16, 2020

Conversation

ialidzhikov
Copy link
Member

What this PR does / why we need it:
Accept openstack for storage provider, not os.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`etcd-druid` does now accept `openstack` for spec.backup.store.provider.

@ialidzhikov ialidzhikov requested a review from a team as a code owner April 16, 2020 07:29
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 16, 2020
georgekuruvillak
georgekuruvillak approved these changes Apr 16, 2020
View reviewed changes
Copy link

@georgekuruvillak georgekuruvillak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@georgekuruvillak georgekuruvillak merged commit 8de15f8 into gardener:master Apr 16, 2020
swapnilgm
swapnilgm approved these changes Apr 16, 2020
View reviewed changes
Copy link

@swapnilgm swapnilgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@swapnilgm swapnilgm swapnilgm approved these changes

@georgekuruvillak georgekuruvillak georgekuruvillak approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @georgekuruvillak @swapnilgm @rfranzke @gardener-robot-ci-3