Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rel-v0.12] Fix podManagementPolicy for scale-up scenario #406

Merged
merged 1 commit into from
Aug 18, 2022
Merged

[rel-v0.12] Fix podManagementPolicy for scale-up scenario #406

merged 1 commit into from
Aug 18, 2022

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Aug 15, 2022

How to categorize this PR?

/area high-availability
/kind bug

What this PR does / why we need it:
This PR fixes a bug which caused a scaled-up etcd (etcd.spec.replicas: 1 -> 3) cluster having the wrong sts.spec.podManamgentPolicy.
This field must be set to Parallel, esp. if the cluster is afterwards scaled down (etcd.spec.replicas: 0) and scaled up (etcd.spec.replicas: 3) again. This is a common case when Gardener hibernates and wakes up shoot clusters.

Special notes for your reviewer:
/cc @shreyas-s-rao @aaronfern

Release note:

This PR fixes an issue which caused the `sts.spec.podManagementPolicy` not to be updated to `Parallel` if an existing etcd cluster is scaled-up from `1 -> x`. This can cause an issue if the cluster is afterwards completely scaled-down (aka hibernation) and scaled-up again.

@timuthy timuthy requested a review from a team as a code owner August 15, 2022 14:51
@gardener-robot gardener-robot added area/high-availability High availability related kind/bug Bug needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Aug 15, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 15, 2022
aaronfern
aaronfern reviewed Aug 16, 2022
View reviewed changes
Copy link
Contributor

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @timuthy!

Just one general question

pkg/component/etcd/statefulset/statefulset.go Show resolved Hide resolved
@aaronfern aaronfern added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 16, 2022
aaronfern
aaronfern approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 16, 2022
@timuthy timuthy added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 16, 2022
@timuthy timuthy merged commit d65c557 into gardener:hotfix-v0.12 Aug 18, 2022
@timuthy timuthy deleted the fix.sts-recreation branch August 18, 2022 11:56
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall left review comments

@aaronfern aaronfern aaronfern approved these changes

Assignees
No one assigned
Labels
area/high-availability High availability related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timuthy @unmarshall @aaronfern @gardener-robot-ci-2 @gardener-robot