-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
❇️ Populate system default root-ca-certificate with ca-bundle #40
❇️ Populate system default root-ca-certificate with ca-bundle #40
Conversation
Signed-off-by: Swapnil Mhamane <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Overall LGTM. I've suggested a minor naming change to keep consistent with other naming changes.
Co-Authored-By: Shreyas Rao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find. I have tested it out. Works well. LGTM
@georgekuruvillak Will you please merge this PR. And release the hotfix. This is urgently needed fix for alicloud deployment. |
Change in the bootstrap ConfigMap leads the checksum annotation |
@ialidzhikov Sure. We will try to maintain those details in release notes. |
Signed-off-by: Swapnil Mhamane [email protected]
What this PR does / why we need it:
apk
to download appropriate wget version, which makes it self-contained.Which issue(s) this PR fixes:
Fixes #39
Special notes for your reviewer:
Please test whether certificate based operation are performed properly on etcd container.
Release note: