Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priority class name, use same temp directory as before #35

Merged
merged 3 commits into from
Apr 2, 2020

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Apr 2, 2020

What this PR does / why we need it:
Added the gardener-shoot-control-plane priority class to the etcd pods and changed the temporary directory path for the snapstore from /tmp to /var/etcd/data/temp.
Also, changed back the value of --etcd-connection-timeout to 5m (instead of 30s) as it was before introduction of etcd-druid.

Release note:

Added the `gardener-shoot-control-plane` priority class to the etcd pods and changed the temporary directory path for the snapstore from `/tmp` to `/var/etcd/data/temp`.

@rfranzke rfranzke requested a review from a team as a code owner April 2, 2020 04:43
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 2, 2020
@rfranzke rfranzke force-pushed the improvements branch 2 times, most recently from 1fe8036 to cc03752 Compare April 2, 2020 04:50
go.mod Show resolved Hide resolved
controllers/etcd_controller.go Show resolved Hide resolved
@rfranzke rfranzke requested a review from swapnilgm April 2, 2020 05:18
Copy link

@georgekuruvillak georgekuruvillak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@georgekuruvillak georgekuruvillak merged commit d797f9b into master Apr 2, 2020
@rfranzke rfranzke deleted the improvements branch April 2, 2020 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants