Added predicates to the controller mgr with option reconcile only if annotation present. #33

georgekuruvillak · 2020-03-25T17:35:35Z

What this PR does / why we need it:
This PR does the following:

remove lastError after successful reconciliation
fix the labels/selector issue in the statefulset manifest
introduce .status.observedGeneration
only reconcile if gardener.cloud/operation=reconcile and oldMeta.generation != newMeta.generation
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

* Removed .status.lastError after successful reconciliation
* Fixed the labels/selector issue in the statefulset manifest
* Introduced .status.observedGeneration
* Added logic to only reconcile if `gardener.cloud/operation=reconcil`e and `oldMeta.generation != newMeta.generation` or `.status.LastError != nil`

controllers/etcd_controller.go

amshuman-kr

Can you please updated the release notes?

shreyas-s-rao

Just a typo

api/v1alpha1/etcd_types.go

controllers/etcd_controller.go

pkg/predicate/predicate.go

controllers/etcd_controller.go

pkg/predicate/predicate.go

pkg/predicate/mapper.go

controllers/etcd_controller.go

rfranzke

/lgtm

amshuman-kr

@georgekuruvillak I have make some small suggestions/change requests.

charts/etcd/templates/etcd-statefulset.yaml

api/v1alpha1/etcd_types.go

config/crd/bases/druid.gardener.cloud_etcds.yaml

controllers/etcd_controller.go

pkg/predicate/predicate.go

… if annotation present. Apply suggestions from code review Co-Authored-By: Amshuman K R <[email protected]>

amshuman-kr

Thanks for the changes!

georgekuruvillak requested a review from a team as a code owner March 25, 2020 17:35

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 25, 2020

gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 25, 2020

rfranzke reviewed Mar 25, 2020

View reviewed changes

controllers/etcd_controller.go Outdated Show resolved Hide resolved

amshuman-kr suggested changes Mar 25, 2020

View reviewed changes

georgekuruvillak force-pushed the predicates_annotation branch from acd3dd1 to 6d6b04e Compare March 26, 2020 09:06

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2020

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2020

georgekuruvillak force-pushed the predicates_annotation branch from 6d6b04e to 4908026 Compare March 26, 2020 09:13

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 26, 2020

shreyas-s-rao reviewed Mar 26, 2020

View reviewed changes

api/v1alpha1/etcd_types.go Outdated Show resolved Hide resolved

controllers/etcd_controller.go Outdated Show resolved Hide resolved

pkg/predicate/predicate.go Outdated Show resolved Hide resolved

georgekuruvillak force-pushed the predicates_annotation branch from 4908026 to e80ecf7 Compare March 26, 2020 10:15

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2020

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2020

georgekuruvillak force-pushed the predicates_annotation branch from e80ecf7 to 78061f4 Compare March 26, 2020 10:17

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 26, 2020

georgekuruvillak force-pushed the predicates_annotation branch from 78061f4 to a48e1f5 Compare March 26, 2020 14:29

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2020

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 26, 2020

georgekuruvillak changed the title ~~[WIP] Added predicates to the controller mgr with option reconcile only if annotation present.~~ Added predicates to the controller mgr with option reconcile only if annotation present. Mar 26, 2020

georgekuruvillak changed the title ~~Added predicates to the controller mgr with option reconcile only if annotation present.~~ [WIP] Added predicates to the controller mgr with option reconcile only if annotation present. Mar 27, 2020

rfranzke requested changes Mar 27, 2020

View reviewed changes

rfranzke requested a review from timuthy March 27, 2020 08:11

rfranzke assigned rfranzke, amshuman-kr, timuthy and shreyas-s-rao Mar 27, 2020

rfranzke approved these changes Mar 29, 2020

View reviewed changes

rfranzke changed the title ~~[WIP] Added predicates to the controller mgr with option reconcile only if annotation present.~~ Added predicates to the controller mgr with option reconcile only if annotation present. Mar 29, 2020

rfranzke requested a review from amshuman-kr March 29, 2020 11:06

amshuman-kr suggested changes Mar 29, 2020

View reviewed changes

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2020

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2020

georgekuruvillak force-pushed the predicates_annotation branch from 0d90d3a to 710708e Compare March 29, 2020 12:47

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2020

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2020

georgekuruvillak force-pushed the predicates_annotation branch from 710708e to 995dfbf Compare March 29, 2020 14:25

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2020

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2020

georgekuruvillak force-pushed the predicates_annotation branch from 995dfbf to 6269598 Compare March 29, 2020 14:50

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2020

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2020

georgekuruvillak force-pushed the predicates_annotation branch from 6269598 to 9aab650 Compare March 29, 2020 14:52

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 29, 2020

georgekuruvillak force-pushed the predicates_annotation branch from 9aab650 to 6e21f6b Compare March 29, 2020 15:06

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2020

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2020

Added predicates to the controller manager with option reconcile only…

db1081f

… if annotation present. Apply suggestions from code review Co-Authored-By: Amshuman K R <[email protected]>

georgekuruvillak force-pushed the predicates_annotation branch from 6e21f6b to db1081f Compare March 29, 2020 15:20

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 29, 2020

rfranzke requested a review from amshuman-kr March 29, 2020 15:31

amshuman-kr approved these changes Mar 29, 2020

View reviewed changes

amshuman-kr merged commit 534c30c into gardener:master Mar 29, 2020

georgekuruvillak deleted the predicates_annotation branch March 29, 2020 15:55

rfranzke mentioned this pull request Apr 7, 2020

ShootNotFailed predicate not working as expected gardener/gardener#2145

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added predicates to the controller mgr with option reconcile only if annotation present. #33

Added predicates to the controller mgr with option reconcile only if annotation present. #33

georgekuruvillak commented Mar 25, 2020 •

edited

Loading

amshuman-kr left a comment

shreyas-s-rao left a comment

rfranzke left a comment

amshuman-kr left a comment

amshuman-kr left a comment

Added predicates to the controller mgr with option reconcile only if annotation present. #33

Added predicates to the controller mgr with option reconcile only if annotation present. #33

Conversation

georgekuruvillak commented Mar 25, 2020 • edited Loading

amshuman-kr left a comment

Choose a reason for hiding this comment

shreyas-s-rao left a comment

Choose a reason for hiding this comment

rfranzke left a comment

Choose a reason for hiding this comment

amshuman-kr left a comment

Choose a reason for hiding this comment

amshuman-kr left a comment

Choose a reason for hiding this comment

georgekuruvillak commented Mar 25, 2020 •

edited

Loading