Fixed concurrency bug when etcd-druid runs more than one worker #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-3
added
reviewed/ok-to-test
amshuman-kr
suggested changes
Mar 20, 2020
controllers/etcd_controller.go
Outdated
| var err error | ||
| decoded := &corev1.ConfigMap{} | ||
| configMapPath := getChartPathForConfigMap() | ||
| if _, ok := r.RenderedChart.Files()[configMapPath]; !ok { | ||
| chartPath := getChartPath() | ||
| renderedChart, err := r.ChartApplier.Render(chartPath, etcd.Name, etcd.Namespace, *values) |
There was a problem hiding this comment.
Why render again and again? Why not do it once and pass it as a parameter to the func?
There was a problem hiding this comment.
We have to refactor extensively again. I shall optimise this in that cycle.
georgekuruvillak
force-pushed
the
hotfix-v0.1.6
branch
from
9fc8e6d to
a024d72
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
swapnilgm
approved these changes
Mar 20, 2020
controllers/etcd_controller.go
Outdated
| return nil, err | ||
| } | ||
| values["configMapName"] = cm.Name |
There was a problem hiding this comment.
Similar line should have been there for statefulset like values["name"] = ss.Name. But considering gardener that won't be case. And this is backward compatibility code. So, the change is optional.
georgekuruvillak
force-pushed
the
hotfix-v0.1.6
branch
from
a024d72 to
d727a2d
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
amshuman-kr
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the issue related to concurrent reconcilation of etcd resources messing up configmap, service and statefulset values.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: