Bug-fixes value-defaulting #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
reviewed/ok-to-test
|
@amshuman-kr There were some bugs fixes associated with conversion of values that resulted in incorrent conversions example int conversion of size resources etc. PTAL. I have created a hotfix as well. Will trigger the release post to the review. |
georgekuruvillak
force-pushed
the
bugfixes_valuedefaulting
branch
from
37c64d7 to
fe43f22
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
georgekuruvillak
force-pushed
the
bugfixes_valuedefaulting
branch
from
fe43f22 to
b97a977
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
amshuman-kr
suggested changes
Mar 6, 2020
georgekuruvillak
force-pushed
the
bugfixes_valuedefaulting
branch
from
b97a977 to
4aa8959
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
amshuman-kr
suggested changes
Mar 6, 2020
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
georgekuruvillak
force-pushed
the
bugfixes_valuedefaulting
branch
from
31b28fd to
5b9af5f
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
|
@georgekuruvillak I don't see the variable name changes you marked as resolved. |
Co-Authored-By: Amshuman K R <[email protected]>
gardener-robot-ci-2
added
reviewed/ok-to-test
amshuman-kr
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds default values to values.yaml. It also takes care of go-template value conversion issues.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: