Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate full snapshot #86

Merged
merged 1 commit into from
Dec 28, 2018
Merged

Avoid duplicate full snapshot #86

merged 1 commit into from
Dec 28, 2018

Conversation

swapnilgm
Copy link
Contributor

@swapnilgm swapnilgm commented Dec 14, 2018 •
edited
Loading

What this PR does / why we need it:
Currently we blindly update take new full snapshot, even if last full snapshot was taken on same etcd revision. This PR skips duplicate full snapshot in case there is no update on etcd since last full snapshot.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

It now skips full snapshot if there were no updates on the etcd since previous full snapshot.

@swapnilgm swapnilgm added kind/enhancement Enhancement, improvement, extension size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) needs/review Needs review platform/all priority/normal needs/lgtm Needs approval for merging area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) status/new Issue is new and unprocessed labels Dec 14, 2018
@swapnilgm swapnilgm force-pushed the avoid-unnecessary-snap branch from 21aabc1 to 8190db7 Compare December 21, 2018 10:39
shreyas-s-rao
shreyas-s-rao approved these changes Dec 27, 2018
View reviewed changes
Copy link
Collaborator

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swapnilgm Thanks for the well-written PR! LGTM 👍🏼

@swapnilgm swapnilgm force-pushed the avoid-unnecessary-snap branch from 8190db7 to dfed841 Compare December 28, 2018 10:30
@swapnilgm swapnilgm added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging and removed needs/lgtm Needs approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review status/new Issue is new and unprocessed labels Dec 28, 2018
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 28, 2018
@swapnilgm swapnilgm merged commit 7581cfc into gardener:master Dec 28, 2018
@swapnilgm swapnilgm deleted the avoid-unnecessary-snap branch December 28, 2018 10:49
@PadmaB PadmaB modified the milestones: 0.4.1, --- Jan 23, 2019
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

@georgekuruvillak georgekuruvillak Awaiting requested review from georgekuruvillak

Assignees
No one assigned
Labels
area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/all reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
---
Development

Successfully merging this pull request may close these issues.
5 participants
@swapnilgm @shreyas-s-rao @PadmaB @gardener-robot-ci-1 @gardener-robot