Add mock test for GCS #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swapnilgm
added
platform/gcp
swapnilgm
force-pushed
the
gcs-mock-test
branch
from
273d1bb to
b68d25f
Compare
shreyas-s-rao
requested changes
Dec 26, 2018
There was a problem hiding this comment.
@swapnilgm Thanks for the well-written PR! Other than a couple of minor changes in the comments, it looks good to me. Please address those changes. Thanks.
pkg/snapstore/gcs_snapstore.go
Outdated
| "github.com/sirupsen/logrus" | ||
| "google.golang.org/api/iterator" | ||
| ) | ||
|
|
||
| // GCSSnapStore is snapstore with local disk as backend | ||
| // GCSSnapStore is snapstore with local disk as backend. |
There was a problem hiding this comment.
Modify comment to GCSSnapStore is a GCS-backed snapstore.
Also have a look at
swapnilgm
force-pushed
the
gcs-mock-test
branch
3 times, most recently
from
f8fcffb to
731b3a7
Compare
Signed-off-by: Swapnil Mhamane <[email protected]>
swapnilgm
force-pushed
the
gcs-mock-test
branch
from
731b3a7 to
932c106
Compare
swapnilgm
added
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
|
@shreyas-s-rao Thank you for the review. And sorry for the delay. I have updated the PR. PTAL. |
gardener-robot
added
priority/3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Swapnil Mhamane [email protected]
What this PR does / why we need it:
This PR adds mock client for GCS snapstore. Please check #70 for further details.
Which issue(s) this PR fixes:
Fixes #70
Special notes for your reviewer:
Please check the GCS support throully.
Release note: