Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Upgrade dependencies, and standardize the yaml dependency #796

Merged
merged 5 commits into from
Nov 8, 2024
Merged

⬆️ Upgrade dependencies, and standardize the yaml dependency #796

merged 5 commits into from
Nov 8, 2024

Conversation

renormalize
Copy link
Member

What this PR does / why we need it:

  • Standardizes the yaml dependency to sigs.k8s.io/yaml.
  • Removes the deprecated k8s.io/utils/pointer package, and replaces it with k8s.io/utils/ptr.
  • Replace the deprecated github.com/golang/mock dependency with go.uber.org/mock.
  • Upgrades a bunch of direct dependencies.

Release note:

Standardize the `yaml` dependency to `sigs.k8s.io/yaml`. Replace deprecated `k8s.io/utils/pointer` with `k8s.io/utils/ptr`. Bump all direct dependencies to newer versions.

@renormalize
Upgraded direct dependencies.
ddcef96 
* Upgraded `github.com/onsi/ginkgo/v2` to `v2.20.2`.

* Upgraded `github.com/onsi/gomega` to `v1.34.2`.

* Upgraded `github.com/prometheus/client_golang` to `v1.20.4`.

* Upgraded `github.com/spf13/cobra` to `v1.8.1`.

* Upgraded `go.uber.org/zap` to `v1.27.0`.
@renormalize
Standardize the yaml dependency to sigs.k8s.io/yaml.
d7966af 
* Removed the dependency on `github.com/ghodss/yaml`.

* Removed the dependency on `gopkg.in/yaml.v2`.

* Upgrade `sigs.k8s.io/yaml` to the latest verion.
@renormalize
Replace the deprecated github.com/golang/mock dependency with `go.u…
e062884 
…ber.org/mock`.
@renormalize
Upgrade the k8s.io/utils dependency.
4f8bcbb 
* Remove all usages of the deprecated `k8s.io/utils/pointer` package
  and replace them with `k8s.io/utils/ptr`.
@renormalize
Upgrade the sigs.k8s.io/controller-runtime dependency.
1881e0b 
* Upgrade the `sigs.k8s.io/controller-runtime` dependency to `v0.17.5`.

* Upgrade the `k8s.io/api` dependency to `v0.29.2`.

* Upgrade the `k8s.io/apimachinery` dependency to `v0.29.2`.

* Upgrade the `k8s.io/client-go` dependency to `v0.29.2`.
@renormalize renormalize added area/dev-productivity Developer productivity related (how to improve development) area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up dependencies Pull requests that update a dependency file labels Nov 8, 2024
@renormalize renormalize added this to the v0.31.0 milestone Nov 8, 2024
@renormalize renormalize requested a review from a team as a code owner November 8, 2024 09:03
@gardener-robot gardener-robot added the needs/review Needs review label Nov 8, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 8, 2024
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 8, 2024
seshachalam-yv
seshachalam-yv approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @renormalize, for replacing the deprecated dependencies.
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 8, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 8, 2024
anveshreddy18
anveshreddy18 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@anveshreddy18 anveshreddy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrades
LGTM!

@renormalize renormalize merged commit 0bcd93a into gardener:master Nov 8, 2024
9 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 8, 2024
@renormalize renormalize deleted the upgrade-dependencies branch November 15, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

@anveshreddy18 anveshreddy18 anveshreddy18 approved these changes

Assignees

@renormalize renormalize

@anveshreddy18 anveshreddy18

Labels
area/dev-productivity Developer productivity related (how to improve development) area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related dependencies Pull requests that update a dependency file kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.31.0
Development

Successfully merging this pull request may close these issues.
5 participants
@renormalize @anveshreddy18 @seshachalam-yv @gardener-robot-ci-3 @gardener-robot