Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a detection for a single member restoration when snapstore is not configured for zeroth pod. #761

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fix a detection for a single member restoration when snapstore is not configured for zeroth pod. #761

merged 1 commit into from
Aug 20, 2024

Conversation

ishan16696
Copy link
Member

@ishan16696 ishan16696 commented Aug 13, 2024 •
edited
Loading

What this PR does / why we need it:
This PR will fix a bug in detection of a single member restoration case when snapstore is not configured for zeroth pod.

Which issue(s) this PR fixes:
Fixes #760

Special notes for your reviewer:

Release note:

Fixed a bug in detecting single member restoration scenario for the zeroth pod and when no storage provider for backups is configured.

@ishan16696 ishan16696 requested a review from a team as a code owner August 13, 2024 04:41
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 13, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 13, 2024
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Aug 13, 2024
@ishan16696 ishan16696 added this to the v0.30.0 milestone Aug 19, 2024
seshachalam-yv
seshachalam-yv approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Aug 20, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 20, 2024
@ishan16696 ishan16696 merged commit 5d011d7 into gardener:master Aug 20, 2024
9 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 20, 2024
@ishan16696 ishan16696 deleted the fix/bug/restoration branch August 20, 2024 09:17
ishan16696 added a commit to ishan16696/etcd-backup-restore that referenced this pull request Aug 29, 2024
@ishan16696
Fix a detection for a single member restoration when snapstore is not…
a62b7c6 
… configured for zeroth pod. (gardener#761)
@ishan16696 ishan16696 mentioned this pull request Aug 29, 2024
Merged
ishan16696 added a commit that referenced this pull request Aug 30, 2024
@ishan16696
Fix a detection for a single member restoration when snapstore is not…
ea9a6be 
… configured for zeroth pod. (#761) (#766)
@ishan16696 ishan16696 mentioned this pull request Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.30.0
5 participants
@ishan16696 @seshachalam-yv @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot