Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rel-v0.28] Full snapshot lease update retry on failure #747

Conversation

anveshreddy18
Copy link
Contributor

@anveshreddy18 anveshreddy18 commented Jul 3, 2024

What this PR does / why we need it:

cherry-pick of PR #711, #720, and #744 combined together

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Introduce periodic updates to the Full Snapshot Lease, addressing delays in lease updates during failures

@anveshreddy18 anveshreddy18 requested a review from a team as a code owner July 3, 2024 17:32
@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jul 3, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 3, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 3, 2024
@anveshreddy18 anveshreddy18 changed the title [Bug fix] Full snapshot lease update retry on failure [rel-v0.28] Full snapshot lease update retry on failure Jul 3, 2024
Copy link
Member

@renormalize renormalize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @anveshreddy18.

Could you update the description to reflect that this PR is a cherry-pick of #711, #720, and #744?

I also feel that reviewing cherry-pick PRs would be easier if the cherry-picks aren't squashed before creating the PR.
That way, each commit can be verified to correspond to the diffs that a particular merged PR to master brought.

It would also maintain the same commit messages (when squashed and merged to this branch) that are present in the master branch, so it is easy to map changes in this branch and master.

@anveshreddy18
Copy link
Contributor Author

@renormalize Out of these three PR's, the first one contains most of the functionality and since the other two PR's were just reverts and don't add anything, it was advised by @ishan16696 to not add those commits. But I agree it would make the reviewer's life easier in general, but in this case, since these are reverts, I didn't want to include them as commits. I hope this is fine.

Copy link
Member

@renormalize renormalize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified to have the same diff as the three PRs mentioned. Thanks.

@ishan16696
Copy link
Member

Out of these three PR's, the first one contains most of the functionality and since the other two PR's were just reverts and don't add anything, it was advised by @ishan16696 to not add those commits

Just 1 nit-pick, this PR can be splitted into 2 commits. 1 commit for cherry-pick and another commit for all reverts on top of that cherry-pick. May be I wasn't able to convey it properly. Anyway it look good.

Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ashwani2k
Copy link
Collaborator

ashwani2k commented Jul 5, 2024

Tested the scenario and it tries to renew the full snapshot lease every 1 min now.
We can merge this one.

@anveshreddy18 anveshreddy18 merged commit dfcf84e into gardener:rel-v0.28 Jul 5, 2024
9 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants