Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rel-v0.24] Fix regression in chunk deletion for openstack provider (#703) #704

Merged
merged 1 commit into from
Jan 9, 2024
Merged

[rel-v0.24] Fix regression in chunk deletion for openstack provider (#703) #704

merged 1 commit into from
Jan 9, 2024

Conversation

shreyas-s-rao
Copy link
Collaborator

What this PR does / why we need it:
Cherry-pick of #703

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/invite @ishan16696

Release note:

A regression in chunk deletion behavior for openstack provider has now been fixed.

@shreyas-s-rao
Fix regression in chunk deletion for openstack provider (gardener#703)
53bde33 
* Fix bug in chunk deletion for openstack

* Remove backward compatibility tests for GC, other minor fixes in snapshotter_test.go

* Fix unit tests

* Address review comments from @ishan16696

* Address review comments from @anveshreddy18
@shreyas-s-rao shreyas-s-rao added kind/bug Bug area/backup Backup related labels Jan 9, 2024
@shreyas-s-rao shreyas-s-rao added this to the v0.28.0 milestone Jan 9, 2024
@shreyas-s-rao shreyas-s-rao requested a review from a team as a code owner January 9, 2024 15:09
@gardener-robot gardener-robot added the needs/review Needs review label Jan 9, 2024
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jan 9, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 9, 2024
ishan16696
ishan16696 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishan16696 ishan16696 merged commit b3a83ed into gardener:rel-v0.24 Jan 9, 2024
9 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 9, 2024
@shreyas-s-rao shreyas-s-rao deleted the swift-chunk-deletion-gc/rel-v0.24 branch January 9, 2024 16:55
@shreyas-s-rao shreyas-s-rao self-assigned this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishan16696 ishan16696 ishan16696 approved these changes

Assignees

@shreyas-s-rao shreyas-s-rao

Labels
area/backup Backup related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.28.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shreyas-s-rao @ishan16696 @gardener-robot-ci-3 @gardener-robot