-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FakeGCS] Add a new field emulatorEnabled
in gcp secret & configure Gcloud client for GCS Emulator
#697
[FakeGCS] Add a new field emulatorEnabled
in gcp secret & configure Gcloud client for GCS Emulator
#697
Conversation
enableGCSEmulator
in gcp secret & configure Gcloud client for GCS EmulatorenableGCSEmulator
in gcp secret & configure Gcloud client for GCS Emulator
enableGCSEmulator
in gcp secret & configure Gcloud client for GCS EmulatorenableGCSEmulator
in gcp secret & configure Gcloud client for GCS Emulator
example/storage-provider-secrets/04-google-cloud-storage-secret.yaml
Outdated
Show resolved
Hide resolved
enableGCSEmulator
in gcp secret & configure Gcloud client for GCS EmulatoremulatorEnabled
in gcp secret & configure Gcloud client for GCS Emulator
@anveshreddy18 please also modify the release note to talk about how to enable emulator for etcdbrctl command, rather than from the provider secret perspective. Something like
This mentions to users of both |
62b46fd
to
43d4c4a
Compare
@anveshreddy18 You need rebase this pull request with latest master branch. Please check. |
…nt for GCS Emulator
43d4c4a
to
bce3cef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for also reflecting the changes in Azure with regards to naming convention, @anveshreddy18.
Testing will be significantly easier for GCS and Azure; now that emulators are supported for the three major providers.
Remove the unnecessary commit messages from the squash commit before merging for a cleaner commit message and history.
Thanks!
What this PR does / why we need it:
emulatorEnabled
in gcp secretemulatorEnabled
istrue
This is helpful to run
etcdbr
tests locally and on pipelines without actually using the real infra. This can also be used by Etcd-druid to use GCS Emulator fake-gcs-server for running e2e-tests.For these, Google cloud client in
backup-restore
has to be configured to connect to the Emulator.This PR enables that in either of the two ways
GOOGLE_EMULATOR_ENABLED
env var is set when runningetcdbr
as a process usingetcdbrctl
emulatorEnabled
field in the gcp secret is set totrue
via helm chartWhich issue(s) this PR fixes:
Fixes #696
Special notes for your reviewer:
Release note: