Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch GCR -> Artifact-Registry #688

Merged
merged 2 commits into from
Dec 12, 2023
Merged

switch GCR -> Artifact-Registry #688

merged 2 commits into from
Dec 12, 2023

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Dec 6, 2023

GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

  • europe-docker.pkg.dev/gardener-project/snapshots for snapshots
  • europe-docker.pkg.dev/gardener-project/releases for releases
  • europe-docker.pkg.dev/gardener-project/public for combined view of snapshots + releases

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr

Release note:

Change OCI Image Registry from GCR (`eu.gcr.io/gardener-project`) to Artifact-Registry (`europe-docker.pkg.dev/gardener-project/releases`). Users should update their references.

@ccwienk
cleanup: rm redundant/obsolete attributes
3ce0627
@ccwienk
switch GCR -> Artifact-Registry
058216b 
GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

- europe-docker.pkg.dev/gardener-project/snapshots for snapshots
- europe-docker.pkg.dev/gardener-project/releases for releases
- europe-docker.pkg.dev/gardener-project/public for read-access to
  snapshots + releases

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr
@ccwienk ccwienk requested a review from a team as a code owner December 6, 2023 23:36
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Dec 6, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 6, 2023
@aaronfern aaronfern added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 7, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 7, 2023
shreyas-s-rao
shreyas-s-rao reviewed Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccwienk thanks for adapting the image registry paths. I had one question though, about where the image actually gets pushed to. PTAL

.ci/pipeline_definitions Show resolved Hide resolved
@shreyas-s-rao shreyas-s-rao added the needs/cherry-pick Needs to be cherry-picked to older version label Dec 7, 2023
@shreyas-s-rao shreyas-s-rao mentioned this pull request Dec 7, 2023
Closed
shreyas-s-rao
shreyas-s-rao approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 12, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 12, 2023
@shreyas-s-rao shreyas-s-rao merged commit 648f493 into master Dec 12, 2023
9 checks passed
@shreyas-s-rao shreyas-s-rao deleted the gcr-to-ar branch December 12, 2023 04:48
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 12, 2023
@shreyas-s-rao shreyas-s-rao mentioned this pull request Dec 12, 2023
Merged
@shreyas-s-rao shreyas-s-rao added this to the v0.28.0 milestone Dec 12, 2023
shreyas-s-rao pushed a commit to shreyas-s-rao/etcd-backup-restore that referenced this pull request Jan 11, 2024
@ccwienk @shreyas-s-rao
switch GCR -> Artifact-Registry (gardener#688)
1d0f81c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees
No one assigned
Labels
needs/cherry-pick Needs to be cherry-picked to older version needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.28.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ccwienk @shreyas-s-rao @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot @aaronfern