Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block public access to S3 bucket created by integration tests #615

Merged
merged 2 commits into from
May 3, 2023
Merged

Block public access to S3 bucket created by integration tests #615

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db16c16
Block public access to S3 bucket as per standard compliance rules
shreyas-s-rao Apr 19, 2023
caeb3a8
Deny non-HTTPS requests to S3 buckets created by integration tests
shreyas-s-rao Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .ci/integration_test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,11 @@ function delete_aws_secret() {

function create_s3_bucket() {
echo "Creating S3 bucket ${TEST_ID} in region ${REGION}"
aws s3api create-bucket --bucket ${TEST_ID} --region ${REGION} --create-bucket-configuration LocationConstraint=${REGION}
aws s3api create-bucket --bucket ${TEST_ID} --region ${REGION} --create-bucket-configuration LocationConstraint=${REGION} --acl private
# Block public access to the S3 bucket
aws s3api put-public-access-block --bucket ${TEST_ID} --public-access-block-configuration "BlockPublicAcls=true,IgnorePublicAcls=true,BlockPublicPolicy=true,RestrictPublicBuckets=true"
shreyas-s-rao marked this conversation as resolved.
Show resolved Hide resolved
# Deny non-HTTPS requests to the S3 bucket
aws s3api put-bucket-policy --bucket ${TEST_ID} --policy "{\"Version\":\"2012-10-17\",\"Statement\":[{\"Effect\":\"Deny\",\"Principal\":\"*\",\"Action\":\"s3:*\",\"Resource\":[\"arn:aws:s3:::${TEST_ID}\",\"arn:aws:s3:::${TEST_ID}/*\"],\"Condition\":{\"Bool\":{\"aws:SecureTransport\":\"false\"},\"NumericLessThan\":{\"s3:TlsVersion\":\"1.2\"}}}]}"
}

function delete_s3_bucket() {
Expand Down