Upgrade Go version to 1.19 #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
There was a problem hiding this comment.
@ishan16696 thanks for the PR. Generally LGTM. Maybe in the same PR can you also upgrade the image from go v1.19.2 to v1.19.3 as it addresses many vulnerabilities such as this one and also mentioned here?
gardener-robot
added
size/s
gardener-robot-ci-1
added
the
reviewed/ok-to-test
done. PTAL |
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
@ishan16696 Thanks for making the requested changes. Please check the failing unit tests. Also, please change the release note to something like: ```noteworthy operator Update golang version for Docker image build to `v1.19.3`.``` ```noteworthy developer Update golang version for dependency vendoring to `v1.19`.``` |
|
/reviewed ok-to-test |
gardener-robot
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
Updated the release note, failing unit tests are just flaky tests. PTAL. |
|
/lgtm |
|
@shreyas-s-rao Command |
gardener-robot
added
reviewed/lgtm
shreyas-s-rao
approved these changes
Dec 7, 2022
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrade Go version to v1.19 for etcd-backup-restore as etcd-druid is also using the Go version v1.19. check here.
This PR updated Go version to v1.19.3 used to build docker image.
This PR also updated the pipeline definitions to use Go v1.19.3
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: