Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member Peer URL not updated when scaled to multi-node, scale identification is also not correct #534

Merged
merged 8 commits into from
Sep 16, 2022
Merged

Member Peer URL not updated when scaled to multi-node, scale identification is also not correct #534

merged 8 commits into from
Sep 16, 2022

Conversation

unmarshall
Copy link
Contributor

@unmarshall unmarshall commented Sep 14, 2022 •
edited
Loading

What this PR does / why we need it:

Member peer URL should always be updated. This will ensure that member peer URL is correct updated even if there was a recreation of sts and as a consequence a new configmap having a cluster size > 1 is available.
It also fixes the way we identify scale up scenario.

Which issue(s) this PR fixes:
Fixes #533

Special notes for your reviewer:

Release note:

Always update member peer URL, changed the way scale-up of etcd cluster is identified.

@unmarshall unmarshall requested a review from a team as a code owner September 14, 2022 08:18
@gardener-robot
Copy link

@unmarshall Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Sep 14, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 14, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 14, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 14, 2022
ishan16696
ishan16696 requested changes Sep 14, 2022
View reviewed changes
Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @unmarshall ,
thanks for PR.
Have you also tested the single member restoration feature with these changes ?

pkg/server/backuprestoreserver.go Outdated Show resolved Hide resolved
pkg/server/backuprestoreserver.go Outdated Show resolved Hide resolved
pkg/server/backuprestoreserver.go Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Sep 14, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 14, 2022
aaronfern
aaronfern requested changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @unmarshall!
Few suggestions from me, looks good otherwise

pkg/miscellaneous/miscellaneous.go Outdated Show resolved Hide resolved
pkg/server/backuprestoreserver.go Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 14, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 14, 2022
@unmarshall
Copy link
Contributor Author

unmarshall commented Sep 14, 2022 •
edited
Loading

Have you also tested the single member restoration feature with these changes ?

@ishan16696 no i have not tested that explicitly. Let us sync up tomorrow and test it out.

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 15, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 15, 2022
@unmarshall unmarshall mentioned this pull request Sep 15, 2022
Merged
ishan16696
ishan16696 requested changes Sep 15, 2022
View reviewed changes
Copy link
Member

@ishan16696 ishan16696 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR for single member restoration. It is working fine.
Just a one nitpick.

pkg/server/backuprestoreserver.go Outdated Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 15, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 15, 2022
aaronfern
aaronfern approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Sep 16, 2022
@unmarshall unmarshall merged commit fcaf570 into gardener:master Sep 16, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 16, 2022
@aaronfern aaronfern mentioned this pull request Sep 16, 2022
Merged
@unmarshall unmarshall deleted the updatemember branch August 21, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfern aaronfern aaronfern approved these changes

@ishan16696 ishan16696 ishan16696 approved these changes

@abdasgupta abdasgupta abdasgupta approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Member Peer URL not updated when scaled to multi-node, scale identification is also not correct
8 participants
@unmarshall @gardener-robot @abdasgupta @ishan16696 @aaronfern @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3