Fix the ProbeEtcd timeout. #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
|
/assign |
gardener-robot
added
reviewed/lgtm
gardener-robot
added
the
status/closed
aaronfern
pushed a commit
to aaronfern/etcd-backup-restore
that referenced
this pull request
Sep 16, 2022
* Fix the ProbeEtcd timeout. * Improved the logging while closing the snapshotter.
aaronfern
added a commit
that referenced
this pull request
Sep 16, 2022
* Fix the ProbeEtcd timeout. (#532) * Fix the ProbeEtcd timeout. * Improved the logging while closing the snapshotter. * always update member peer url and changed the way to identify scaleup * fixed unit tests * addressed review comments * addressed review comments * used Errorf instead of Error * made some modifications on how to initialize peerURLTLSEnabled * removed commented code * addressed review comment - removed commented code * Update to golang 1.18.6 (#535) * Update Dockerfile to use go 1.18.6 * Update pipeline definition to use go 1.18.6 Co-authored-by: Ishan Tyagi <[email protected]> Co-authored-by: Madhav Bhargava <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We have observed that currently
ProbeEtcdis using the longer timeout which is set using this flag--etcd-connection-timeoutand in our landscapes--etcd-connection-timeoutis set to5mins. (check here)Due to this longer Timeout
ProbeEtcdis keep waiting instead of failing the probe and meanwhile whenProbeEtcdis waiting if corresponding etcd comes-up thenProbeEtcdget succeeds this might leads to some race-conditions between the go-routines asProbeEtcdis suppose to fail.This PR fixes this issue by using the shorter Timeout of
5secinProbeEtcd.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
cc @timuthy
Release note: