Handled properly potential of wrong prefix formation in Azure. #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-1
added
reviewed/ok-to-test
|
/lgtm |
gardener-robot
added
reviewed/lgtm
amshuman-kr
changed the title
amshuman-kr
approved these changes
Aug 11, 2021
shreyas-s-rao
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
@abdasgupta @kris94 Thanks for the fix! Please rebase the PR on latest master.
gardener-robot-ci-3
added
the
reviewed/ok-to-test
abdasgupta
changed the title
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
shreyas-s-rao
added
merge/squash
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This a PR fixes a potential bug that may create wrong prefix in Azure backup storage for ETCD.
With v2 directory structure introduced with Compaction PR, it was observed that the blobName comes with the prefix concatenated to it. So if store prefix is set with
--store-prefix=prefixthen the blobName would be prefix/Name and with that Join prefix/prefix/Name, which points to a snapshot that does not exists. This PR resolves this bug.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: