Set the auto-compaction fields for Embedded-Etcd. #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-2
added
reviewed/ok-to-test
amshuman-kr
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Thanks for the fix @ishan16696! /lgtm
/second-opinion
/invite @abdasgupta @shreyas-s-rao
gardener-robot
added
the
needs/second-opinion
shreyas-s-rao
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
@ishan16696 Thanks a lot for noticing this regression and raising the PR for the same. LGTM
|
@abdasgupta You have pull request review open invite, please check |
gardener-robot
added
lifecycle/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Set the auto-compaction fields for Embedded-Etcd which were somehow got removed in this commit of this PR. I think it happened while moving StartEmbeddedEtcd to a different package.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: