Added new metric to capture any snapshotter error #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@aaronfern Thank you for your contribution. |
|
Thank you @aaronfern for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
gardener-robot
added
the
size/s
|
/invite @shreyas-s-rao |
|
/invite @amshuman-kr |
shreyas-s-rao
requested changes
Apr 15, 2021
There was a problem hiding this comment.
@aaronfern Thanks for the well-written first PR! I have added a few comments regarding using the LabelError constant from metrics package. Please address these changes. Thanks.
shreyas-s-rao
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
shreyas-s-rao
added
the
reviewed/ok-to-test
shreyas-s-rao
approved these changes
Apr 16, 2021
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
shreyas-s-rao
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
shreyas-s-rao
added
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
shreyas-s-rao
added
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding a new metric
etcdbr_snapshotter_failureused as a blanket metric to capture any snapshotter error. This will be used to add an alert to the gardener prometheus dashboard to alert the DoD of any backup sidecar error wrt any snapshotter operation failure.This is a precursor to allowing etcd to serve traffic when the backup sidecar is starting up/restarting
Which issue(s) this PR fixes:
Fixes partially #325
Special notes for your reviewer:
Release note: