Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snapshot metrics initialization #223

Merged
merged 1 commit into from
May 13, 2020
Merged

Fix snapshot metrics initialization #223

merged 1 commit into from
May 13, 2020

Conversation

shreyas-s-rao
Copy link
Collaborator

Signed-off-by: Shreyas Rao [email protected]

What this PR does / why we need it:
This PR fixes a bug with metrics initialization that surfaced due to recent change in initial snapshot logic, due to which false alerts were being raised.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix snapshot metric initialization.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 12, 2020
@shreyas-s-rao shreyas-s-rao added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label May 12, 2020
@shreyas-s-rao shreyas-s-rao changed the title Fix snapshot metrics initialization [WIP] Fix snapshot metrics initialization May 12, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 12, 2020
@shreyas-s-rao shreyas-s-rao changed the title [WIP] Fix snapshot metrics initialization Fix snapshot metrics initialization May 12, 2020
@shreyas-s-rao shreyas-s-rao added needs/lgtm Needs approval for merging needs/review Needs review and removed reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies labels May 12, 2020
swapnilgm
swapnilgm approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@swapnilgm swapnilgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@swapnilgm swapnilgm merged commit ad4008b into gardener:master May 13, 2020
swapnilgm pushed a commit that referenced this pull request May 14, 2020
Merge pull request #223 from shreyas-s-rao/fix/snapshot-init
9deb984 
Fix snapshot metrics initialization
@shreyas-s-rao shreyas-s-rao deleted the fix/snapshot-init branch May 14, 2020 17:27
@shreyas-s-rao shreyas-s-rao mentioned this pull request Oct 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnilgm swapnilgm swapnilgm approved these changes

@georgekuruvillak georgekuruvillak Awaiting requested review from georgekuruvillak

Assignees
No one assigned
Labels
needs/lgtm Needs approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shreyas-s-rao @swapnilgm @gardener-robot-ci-1