Add snapstore bucket-related metrics #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-s-rao
added
area/monitoring
shreyas-s-rao
requested review from
georgekuruvillak and
swapnilgm
as code owners
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
swapnilgm
suggested changes
Mar 16, 2020
There was a problem hiding this comment.
First thing, isn't it possible to build query around existing exposed metrics to get both of these counts? I think prometheus supports enough expressions and function to build query. Please give it a try. If it works i don't think we need this PR.
Regarding current PR i have suggested correction please address them. And also please update the metrics doc
Signed-off-by: Shreyas Rao <[email protected]>
shreyas-s-rao
force-pushed
the
bucket-metrics
branch
from
dd393bc to
79983c0
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
|
@swapnilgm Thanks for the review. I've addressed the comments. PTAL. |
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shreyas Rao [email protected]
What this PR does / why we need it:
This PR adds two new metrics
etcdbr_snapstore_latest_deltas_totalandetcdbr_snapstore_latest_deltas_revisions_total, which provide information about the delta snapshots since the latest full snapshot in the snapstore (object store bucket). We assume that etcd-backup-restore process is the only handler of snapshots in the respective snapstore bucket, in order to maintain integrity of these metrics.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: