Expose etcdbr_snapshot_required metric #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-s-rao
added
kind/enhancement
gardener-robot-ci-1
added
needs/ok-to-test
swapnilgm
reviewed
Aug 30, 2019
There was a problem hiding this comment.
Shouldn't there be handling of metrics at https://github.com/gardener/etcd-backup-restore/blob/master/pkg/snapshot/snapshotter/snapshotter.go#L354 ?
|
@swapnilgm That check is only to see if a delta snapshot is required, so it doesn't check whether a full snapshot is required there (atleast at the moment). And again, this code path is taken only when we decide to start with delta snapshot, but not for the case where we start with full snapshot. |
shreyas-s-rao
force-pushed
the
expose-snapshot-required-metric
branch
from
fe51e75 to
8eb44cb
Compare
|
@swapnilgm Thanks for your comments. I've updated the PR. PTAL. |
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
How about post restoration, if triggered? Shouldn't the metric be reset appropriately? |
shreyas-s-rao
force-pushed
the
expose-snapshot-required-metric
branch
from
8eb44cb to
0dc6124
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
|
@PadmaB Once restoration is complete, the snapshotter will start again, and we set the appropriate metric values there. So there's no need to explicitly reset the metrics after restoration. |
shreyas-s-rao
added
reviewed/ok-to-test
swapnilgm
suggested changes
Aug 30, 2019
Signed-off-by: Shreyas Rao <[email protected]>
shreyas-s-rao
force-pushed
the
expose-snapshot-required-metric
branch
from
0dc6124 to
c94dece
Compare
gardener-robot-ci-1
added
needs/ok-to-test
|
@swapnilgm Thanks for your review. I've addressed your comments. PTAL. |
swapnilgm
reviewed
Sep 2, 2019
swapnilgm
reviewed
Sep 2, 2019
swapnilgm
suggested changes
Sep 2, 2019
swapnilgm
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shreyas Rao [email protected]
What this PR does / why we need it:
This PR exposes new metric
etcdbr_snapshot_requiredthat exposes a Gauge metric to indicate whether a snapshot is required to be taken, based on whether a new etcd revision is observed.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Also contains minor linting corrections.
Release note: