[Feature] Expose api to trigger out-of-schedule delta snapshot #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swapnilgm
requested review from
georgekuruvillak and
shreyas-s-rao
as code owners
gardener-robot-ci-1
added
reviewed/ok-to-test
swapnilgm
added
area/backup
shreyas-s-rao
requested changes
Sep 26, 2019
There was a problem hiding this comment.
@swapnilgm Thanks for the well-written PR! There is one case that's not been handled: when delta snapshots are disabled, triggering out-of-schedule delta snapshot is not able to take a delta snapshot because watchCh is not set, so no events are collected. Please fix this. Other than this, LGTM.
swapnilgm
force-pushed
the
feature/trigger-delta-snapshot
branch
from
1beabc1 to
24feaff
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
@shreyas-s-rao PTAL. |
amshuman-kr
reviewed
Sep 27, 2019
Signed-off-by: Swapnil Mhamane <[email protected]>
swapnilgm
force-pushed
the
feature/trigger-delta-snapshot
branch
from
24feaff to
0cdcb0c
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Done |
amshuman-kr
approved these changes
Sep 27, 2019
shreyas-s-rao
requested changes
Sep 27, 2019
There was a problem hiding this comment.
@swapnilgm Thanks for making the requested changes! Overall LGTM. Just a few small corrections here and there. Please address them. Thanks.
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Co-Authored-By: Shreyas Rao <[email protected]> Signed-off-by: Swapnil Mhamane <[email protected]>
swapnilgm
force-pushed
the
feature/trigger-delta-snapshot
branch
from
efeb22e to
045aa57
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot
added
priority/3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Swapnil Mhamane [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #114
Special notes for your reviewer:
Release note: