Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup in-memory events before stopping snapshotter #190

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

swapnilgm
Copy link
Contributor

Signed-off-by: Swapnil Mhamane [email protected]

What this PR does / why we need it:
Currently, in case etcd restarts and there are some events collected by backup restore sidecar in memory, on receiving stop signal via initialisation request due restart of etcd, the next delta snapshot taken post initialization will store duplicate entries in last delta snapshot. Which might lead to corrupt last delta snapshot. This PR fixed the issue by removing those duplicate events in memory.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

[Fix] Cleanup in-memory events before stopping snapshotter.

@swapnilgm swapnilgm added kind/bug Bug priority/critical Needs to be resolved soon, because it impacts users negatively labels Aug 22, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 22, 2019
@swapnilgm swapnilgm merged commit 8639d21 into gardener:master Aug 22, 2019
@swapnilgm swapnilgm deleted the fix/cleanup-in-meory-events branch August 22, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) priority/critical Needs to be resolved soon, because it impacts users negatively
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants