Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add experimental fail below revision flag #184

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Add experimental fail below revision flag #184

merged 1 commit into from
Aug 8, 2019

Conversation

swapnilgm
Copy link
Contributor

@swapnilgm swapnilgm commented Aug 6, 2019 •
edited by shreyas-s-rao
Loading

Main motivation behind this is to help external entity configure revision in case of bucket change or object store prefix change.

Signed-off-by: Swapnil Mhamane [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Added new flag `experimental-fail-below-revision` flag for initializer and `/initialization/start` http call

@swapnilgm swapnilgm added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Aug 6, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 6, 2019
@swapnilgm swapnilgm force-pushed the feature/experimental-revision-check-flag branch from a70c5ac to 8d98b0f Compare August 7, 2019 06:25
@swapnilgm swapnilgm removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Aug 7, 2019
@swapnilgm swapnilgm changed the title [WIP] Add experimental faiil below revision flag Add experimental fail below revision flag Aug 7, 2019
@swapnilgm swapnilgm force-pushed the feature/experimental-revision-check-flag branch 2 times, most recently from 4e92852 to f369fc1 Compare August 7, 2019 09:13
@swapnilgm swapnilgm added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 7, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 7, 2019
@swapnilgm swapnilgm force-pushed the feature/experimental-revision-check-flag branch from f369fc1 to 818e2ac Compare August 7, 2019 10:34
@swapnilgm swapnilgm added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 7, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 7, 2019
shreyas-s-rao
shreyas-s-rao requested changes Aug 8, 2019
View reviewed changes
Copy link
Collaborator

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swapnilgm Thanks for the well-written PR! I have a few suggestions. Please address them.

pkg/initializer/validator/types.go Outdated Show resolved Hide resolved
cmd/initializer.go Outdated Show resolved Hide resolved
@swapnilgm swapnilgm force-pushed the feature/experimental-revision-check-flag branch 2 times, most recently from 1cf5915 to a7c60e3 Compare August 8, 2019 06:31
Add experimental faiil below revision flag
6830260 
Main motivation behind this is to help extenal entity configure revision
in case of bucket change or object store prefix change

Signed-off-by: Swapnil Mhamane <[email protected]>
@swapnilgm swapnilgm force-pushed the feature/experimental-revision-check-flag branch from a7c60e3 to 6830260 Compare August 8, 2019 06:41
shreyas-s-rao
shreyas-s-rao approved these changes Aug 8, 2019
View reviewed changes
Copy link
Collaborator

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shreyas-s-rao shreyas-s-rao added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) component/etcd-backup-restore ETCD Backup & Restore platform/all and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 8, 2019
@shreyas-s-rao shreyas-s-rao added reviewed/lgtm Has approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 8, 2019
@shreyas-s-rao shreyas-s-rao merged commit e62f074 into gardener:master Aug 8, 2019
@swapnilgm swapnilgm deleted the feature/experimental-revision-check-flag branch August 9, 2019 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

@georgekuruvillak georgekuruvillak Awaiting requested review from georgekuruvillak

Assignees
No one assigned
Labels
component/etcd-backup-restore ETCD Backup & Restore needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/all reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swapnilgm @shreyas-s-rao @gardener-robot-ci-1