Optimize WAL verification #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shreyas Rao <[email protected]>
shreyas-s-rao
added
kind/enhancement
gardener-robot-ci-1
added
reviewed/ok-to-test
|
I have also run memory profiling for master and this PR, to visualize the reduction in memory usage and time taken for data validation. Master - uses wal package's ReadAll() method This PR - uses wal package's new Verify() function The test has been run on a 700MB DB size with a 1.3GB wal dir size (2GB total data dir size). As you can see, the memory usage has drastically dropped (from linear increase till 2GB to a steady usage of 7MB and within max 15MB), and is now independent of wal dir size. Also, the time taken for wal verification has drastically reduced (from 3s to less than 1s). |
swapnilgm
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shreyas Rao [email protected]
What this PR does / why we need it:
This PR optimizes WAL verification memory usage by utilizing the recently added
wal.Verify()feature in etcd 3.3.13.Which issue(s) this PR fixes:
Fixes #120
Special notes for your reviewer:
Release note: