Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang to 1.12.0 #132

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Update golang to 1.12.0 #132

merged 1 commit into from
Mar 5, 2019

Conversation

ialidzhikov
Copy link
Member

What this PR does / why we need it:
https://golang.org/doc/go1.12

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The golang version has been upgraded to `v1.12.0`.

@ialidzhikov
Update golang to 1.12.0
22f76ac 
Signed-off-by: ialidzhikov <[email protected]>
@swapnilgm swapnilgm added exp/beginner Issue that requires only basic skills reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) component/etcd-backup-restore ETCD Backup & Restore platform/all priority/normal reviewed/lgtm Has approval for merging labels Mar 5, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 5, 2019
swapnilgm
swapnilgm approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@swapnilgm swapnilgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@swapnilgm swapnilgm merged commit 870517f into gardener:master Mar 5, 2019
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnilgm swapnilgm swapnilgm approved these changes

@georgekuruvillak georgekuruvillak Awaiting requested review from georgekuruvillak

@shreyas-s-rao shreyas-s-rao Awaiting requested review from shreyas-s-rao

Assignees
No one assigned
Labels
component/etcd-backup-restore ETCD Backup & Restore exp/beginner Issue that requires only basic skills needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/all reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ialidzhikov @swapnilgm @gardener-robot-ci-1 @gardener-robot